Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers/google: Fix read for the backend service resource #7476

Merged
merged 1 commit into from
Aug 8, 2016
Merged

providers/google: Fix read for the backend service resource #7476

merged 1 commit into from
Aug 8, 2016

Conversation

evandbrown
Copy link
Contributor

This change fixes the backend service resource to correctly read its fields after an update, and adds a test to confirm this behavior.

Acceptance test output:

❯ make testacc TEST=./builtin/providers/google GOOGLE_PROJECT=evandbrown17 GOOGLE_REGION=us-central1 TESTARGS='-run=TestAccComputeBackendService'
==> Checking that code complies with gofmt requirements...
/home/evanbrown/dev/golang/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/07/02 23:36:51 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeBackendService -timeout 120m
=== RUN   TestAccComputeBackendService_basic
--- PASS: TestAccComputeBackendService_basic (80.41s)
=== RUN   TestAccComputeBackendService_withBackend
--- PASS: TestAccComputeBackendService_withBackend (140.34s)
=== RUN   TestAccComputeBackendService_withBackendAndUpdate
--- PASS: TestAccComputeBackendService_withBackendAndUpdate (155.42s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 376.276s

@stack72
Copy link
Contributor

stack72 commented Aug 8, 2016

Thanks @evandbrown - this LGTM!

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeBackendService'                                   1 ↵
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/08 12:20:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeBackendService -timeout 120m
=== RUN   TestAccComputeBackendService_basic
--- PASS: TestAccComputeBackendService_basic (92.22s)
=== RUN   TestAccComputeBackendService_withBackend
--- PASS: TestAccComputeBackendService_withBackend (133.74s)
=== RUN   TestAccComputeBackendService_withBackendAndUpdate
--- PASS: TestAccComputeBackendService_withBackendAndUpdate (151.19s)
=== RUN   TestAccComputeBackendService_withCDNEnabled
--- PASS: TestAccComputeBackendService_withCDNEnabled (61.57s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 438.734s

P.

@stack72 stack72 merged commit 4968f6a into hashicorp:master Aug 8, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/google-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evandbrown @stack72